refactor(core): Add more workflow engine tests (no-changelog) #12385
+995
−178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netroy
changed the title
netroy
force-pushed
the
more-workflow-engine-tests
branch
from
9ef188f to
96bb42a
Compare
n8n-assistant
bot
added
core
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
despairblue
approved these changes
Dec 27, 2024
| * @remarks | ||
| * - Metadata from multiple runs is preserved using run indices | ||
| * - Existing metadata in runData is preserved and merged with new metadata | ||
| * - If no metadata exists or runData is missing, the operation is a no-op |
There was a problem hiding this comment.
Suggested change
| * - If no metadata exists or runData is missing, the operation is a no-op | |
| * - If no metadata exists, the operation is a no-op |
I think runData is always defined and if it isn't that function does not check for that case. Unless I'm misunderstanding the comment.
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
more-workflow-engine-tests
|
| Run status |
|
| Run duration | 04m 42s |
| Commit |
|
| Committer | कारतोफ्फेलस्क्रिप्ट™ |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
483
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Workflow engine continues to lack enough tests. This PR is attempt at chipping away code out of the engine into smaller testable methods, and then adding tests for those methods.
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)