Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Odoo Node): Add support for self signed certificates #12388

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dnplkndll
Copy link

Summary

allow a self signed odoo URL to not report error.

like when bypassing a CDN to avoid bot challenge

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@CLAassistant
Copy link

CLAassistant commented Dec 27, 2024

CLA assistant check
All committers have signed the CLA.

@Joffcom
Copy link
Member

Joffcom commented Dec 27, 2024

Hey @dnplkndll

Is there any reason why you can't use the option below which is now preferred?

https://docs.n8n.io/hosting/configuration/configuration-examples/custom-certificate-authority/

@dnplkndll
Copy link
Author

Hey @dnplkndll

Is there any reason why you can't use the option below which is now preferred?

https://docs.n8n.io/hosting/configuration/configuration-examples/custom-certificate-authority/

laziness? I was just using a previous example but need to review the helm chart https://github.com/8gears/n8n-helm-chart/pull/96/files#diff-7181d4c035d0ad8de7b68726348d1a19a49f10c8d9ea0feceef3a725b79ee8c8
to confirm the volume map support. will check now.

at any rate the ability to work around an issue even if for short term might be useful to prevent outage due to expiration.

@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request labels Dec 27, 2024
@Joffcom
Copy link
Member

Joffcom commented Dec 27, 2024

Hey @dnplkndll,

Thanks for the PR, We have created "GHC-612" as the internal reference to get this reviewed.

One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team.

@n8n-assistant n8n-assistant bot added the in linear Issue or PR has been created in Linear for internal review label Dec 27, 2024
@dnplkndll dnplkndll force-pushed the add-odoo-allow-ssl-ignore branch from 35734c8 to dd1fd02 Compare December 27, 2024 20:59
@Joffcom
Copy link
Member

Joffcom commented Dec 27, 2024

@dnplkndll I will need to check but we introduced the cert option as a quicker and more secure option so we may decide not to accept this PR, I will let you know the outcome in January once I am back to work

@dnplkndll dnplkndll force-pushed the add-odoo-allow-ssl-ignore branch from dd1fd02 to 68f4ec9 Compare December 27, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member in linear Issue or PR has been created in Linear for internal review node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants