Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AI Agent Node): Change Prompt Text Copy (no-changelog) #12442

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

CharlieKolb
Copy link
Contributor

@CharlieKolb CharlieKolb commented Jan 3, 2025

Summary

Change text copy.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/ADO-3059/feature-change-prompt-text-copy

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Jan 3, 2025
@CharlieKolb CharlieKolb changed the title chore(Agent Node): Change Prompt Text Copy feat(Agent Node): Change Prompt Text Copy (no-changelog) Jan 3, 2025
@CharlieKolb CharlieKolb changed the title feat(Agent Node): Change Prompt Text Copy (no-changelog) feat(AI Agent Node): Change Prompt Text Copy (no-changelog) Jan 3, 2025
@CharlieKolb CharlieKolb marked this pull request as ready for review January 3, 2025 11:02
Copy link
Contributor

github-actions bot commented Jan 3, 2025

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Jan 3, 2025

n8n    Run #8566

Run Properties:  status check failed Failed #8566  •  git commit 6af194702a: 🌳 ado-3063 🖥️ browsers:node18.12.0-chrome107 🤖 schedule 🗃️ e2e/*
Project n8n
Branch Review ado-3063
Run status status check failed Failed #8566
Run duration 09m 52s
Commit git commit 6af194702a: 🌳 ado-3063 🖥️ browsers:node18.12.0-chrome107 🤖 schedule 🗃️ e2e/*
Committer Mutasem Aldmour
View all properties for this run ↗︎

Test results
Tests that failed  Failures 13
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 373
View all changes introduced in this branch ↗︎

Tests for review

Failed  12-canvas-actions.cy.ts • 1 failed test

View Output Video

Test Artifacts
Canvas Actions > should connect and disconnect a simple node Test Replay Screenshots Video
Failed  20-workflow-executions.cy.ts • 2 failed tests

View Output Video

Test Artifacts
Workflow Executions > when workflow is saved > should render executions tab correctly Test Replay Screenshots Video
Workflow Executions > when workflow is saved > should load items and auto scroll after filter change Test Replay Screenshots Video
Failed  25-stickies.cy.ts • 10 failed tests

View Output Video

Test Artifacts
Canvas Actions > drags sticky around to top left corner Test Replay Screenshots Video
Canvas Actions > drags sticky around and position/size are saved correctly Test Replay Screenshots Video
Canvas Actions > expands/shrinks sticky from the right edge Test Replay Screenshots Video
Canvas Actions > expands/shrinks sticky from the left edge Test Replay Screenshots Video
Canvas Actions > expands/shrinks sticky from the top edge Test Replay Screenshots Video
Canvas Actions > expands/shrinks sticky from the bottom edge Test Replay Screenshots Video
Canvas Actions > expands/shrinks sticky from the bottom right edge Test Replay Screenshots Video
Canvas Actions > expands/shrinks sticky from the top right edge Test Replay Screenshots Video
Canvas Actions > expands/shrinks sticky from the top left edge, and reach min height/width Test Replay Screenshots Video
Canvas Actions > sets sticky behind node Test Replay Screenshots Video
Failed  21-community-nodes.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  42-nps-survey.cy.ts • 0 failed tests

View Output

Test Artifacts

The first 5 failed specs are shown, see all 39 specs in Cypress Cloud.

@CharlieKolb CharlieKolb merged commit 9674208 into master Jan 3, 2025
37 checks passed
@CharlieKolb CharlieKolb deleted the prompt_copy_ck branch January 3, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants