Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix flaky mapping test (no-changelog) #12449

Merged
merged 4 commits into from
Jan 3, 2025
Merged

test: Fix flaky mapping test (no-changelog) #12449

merged 4 commits into from
Jan 3, 2025

Conversation

mutdmour
Copy link
Contributor

@mutdmour mutdmour commented Jan 3, 2025

Summary

Fix flaky mapping tests. Ensure data to map in test is always in view, by scrolling to top.

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Jan 3, 2025
@mutdmour mutdmour changed the title test: Fix flaky mapping test (no-changelog test: Fix flaky mapping test (no-changelog) Jan 3, 2025
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link

cypress bot commented Jan 3, 2025

n8n    Run #8564

Run Properties:  status check passed Passed #8564  •  git commit a56d21f9ec: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 mutdmour 🗃️ e2e/*
Project n8n
Branch Review fix-mapping
Run status status check passed Passed #8564
Run duration 04m 45s
Commit git commit a56d21f9ec: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 mutdmour 🗃️ e2e/*
Committer Mutasem Aldmour
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 484
View all changes introduced in this branch ↗︎

Copy link
Contributor

github-actions bot commented Jan 3, 2025

✅ All Cypress E2E specs passed

@mutdmour mutdmour merged commit 4d1d5d9 into master Jan 3, 2025
37 checks passed
@mutdmour mutdmour deleted the fix-mapping branch January 3, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants