address pr comments

nRFCloud · May 31, 2024 · c455a41 · c455a41
1 parent 5b261ef
commit c455a41
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 14 deletions.
diff --git a/src/mappings/implicit-dependency-aspect.ts b/src/mappings/implicit-dependency-aspect.ts
@@ -4,15 +4,12 @@ import { findTokens } from "cdktf/lib/tokens/private/resolve.js";
 import { IConstruct } from "constructs";
 
 export class ImplicitDependencyAspect implements IAspect {
-    public readonly target: TerraformResource;
     public readonly dependables: string[];
 
     constructor(
-        target: TerraformResource,
+        public readonly target: TerraformResource,
         public readonly implicitDependencies: TerraformResource[],
     ) {
-        this.target = target;
-        this.implicitDependencies = implicitDependencies;
         this.dependables = this.implicitDependencies.map(dependable);
     }
 

diff --git a/src/mappings/services/iam.ts b/src/mappings/services/iam.ts
@@ -52,16 +52,7 @@ export function registerIamMappings() {
             });
 
             ImplicitDependencyAspect.of(role, [eventualConsistentWait, ...managedPolicies || []]);
-            // if (managedPolicies?.length) {
-            //     const dataSource = new DataAwsIamRole(scope, `${id}-data`, {
-            //         name: role.name,
-            //         dependsOn: managedPolicies,
-            //     });
-            //     eslint-disable-next-line @typescript-eslint/no-explicit-any
-            // (role as any)[LAST_MANAGED_POLICY_DATA_SYMBOL] = dataSource;
-            // }
-            //
-            // Aspects.of(scope).add(new EventualConsistencyWorkaroundAspect(role));
+
             return role;
         },
         attributes: {