Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description in picture lightbox #300

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

R-II
Copy link

@R-II R-II commented Oct 30, 2020

Hello,

I needed to display the media description in the lightbox. It only works with pictures for now.
Sorry about the space and line ending changes.

Thanks for all your work ! Nanogallery 2 is awesome !

Raphaël

@Kris-B
Copy link
Member

Kris-B commented Nov 3, 2020

Hi Raphaël,
Many thanks for your contribution!
I'm not really sure to understand the purpose of your pull request.
Media descriptions can already be displayed in the lightbox, using the 'label' tool in one viewerTool or in the viewerToolbar. 'label' includes title and description.

@R-II
Copy link
Author

R-II commented Nov 3, 2020

Hi,

Technically, I needed a new layout, able to display a large amount of data.

The idea is that labeling in top of the lightbox is perfect for a small description, a title, but I needed a large area that has as much value as the picture, like an art description in a museum or a photo in a magazine. Half picture, half text. Responsible and scrollable.

image

@Kris-B
Copy link
Member

Kris-B commented Dec 29, 2020

@sevarg I'll integrate your PR, but with some modifications (and I need a little bit time...). Thanks for your understanding.

@ajmeese7
Copy link

@sevarg I'll integrate your PR, but with some modifications (and I need a little bit time...). Thanks for your understanding.

Bump, I'm looking for this same feature! Being able to display the text description alongside the image title is pretty important to my use case.

Do you need me to try to make any edits to this attempt in a new PR, or will you be able to take another look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants