Add missing/new chapter languages & their corresponding flags #1976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tried to match languages to the main country that they are spoken in and added corresponding missing country.svg files
the previous svg files weren't rendering very well in android studio ui and replacing them seems to have fixed that there are some other broken ones too but they couldn't be fixed when tried with a new flag.xml
except `hr`, everything seems to render fine now these SVGs were obtained directly from dex from their url: $baseUrl/img/flags/[a-z][a-z].svg
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mainly added all the new chapter languages supported (and forgotten)
fixed some of the current flags so that they render properly in android studio (sr, la, still don't render)
ended up getting flags from dex directly (
/img/flags/[a-z]{2}.svg)maybe it makes sense to just import from
/img/flags/occasionally instead of having to depend on another repo for country flags that might not match exactly or have discrepancies in chapter language <-> country code. Alas there doesn't seem to be a way to automate svg to drawable iiuc /shrug