-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove use of index-provider option #1096
Merged
JPryce-Aklundh
merged 6 commits into
neo4j:dev
from
emmaholmbergohlsson:5-less-index-provider
Nov 5, 2024
Merged
Remove use of index-provider option #1096
JPryce-Aklundh
merged 6 commits into
neo4j:dev
from
emmaholmbergohlsson:5-less-index-provider
Nov 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supplying the index-provider option will no longer have any effect, and a user should not specify it. From 5.26 using the index-provider option will generate a warning. The index-provider has never controlled index behaviour in the 5.x series, and the latest provider will always be the best one.
Hunterness
reviewed
Nov 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments
modules/ROOT/pages/indexes/search-performance-indexes/managing-indexes.adoc
Show resolved
Hide resolved
modules/ROOT/pages/indexes/search-performance-indexes/managing-indexes.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/indexes/search-performance-indexes/managing-indexes.adoc
Outdated
Show resolved
Hide resolved
Hunterness
reviewed
Nov 5, 2024
modules/ROOT/pages/indexes/search-performance-indexes/managing-indexes.adoc
Outdated
Show resolved
Hide resolved
Collaborator
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
Hunterness
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supplying the index-provider option will no longer have any effect, and a user should not specify it. From 5.26 using the index-provider option will generate a warning.
The index-provider has never controlled index behaviour in the 5.x series, and the latest provider will always be the best one.