-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev normalize predicate #804
Conversation
This PR includes documentation updates. You can view the updated docs at https://neo4j-docs-cypher-804.surge.sh |
bb83ebc
to
8160b01
Compare
8160b01
to
0cf84ca
Compare
0cf84ca
to
d9d1c96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gem-neo4j - looks good overall.
I think it might be a good idea, however, to include more about the purposes of normalization. From the examples thus far included, I was not sure when/why Id want to do this (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/normalize - this made it more clear, and maybe we can take some inspiration from it). I don't think we need to say lots on this. Also, I think we should mention something about the different normalization forms. Let's talk about it when you are feeling better again :)
modules/ROOT/pages/deprecations-additions-removals-compatibility.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/deprecations-additions-removals-compatibility.adoc
Outdated
Show resolved
Hide resolved
6143950
to
e6cc76f
Compare
e6cc76f
to
903e6cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. I had a few nitpicks!
@@ -338,6 +338,35 @@ The `name` and `age` for `Peter` are are returned because his name contains "ete | |||
|=== | |||
|
|||
|
|||
[[match-string-is-normalized]] | |||
=== Checking if a `STRING` `IS NORMALIZED` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"STRING
" has mostly been written as "string" in other headers
[[match-string-is-normalized]] | ||
=== Checking if a `STRING` `IS NORMALIZED` | ||
|
||
The `IS NORMALIZED` operator is used to check whether the given `STRING` is in the `NFC` Unicode normalization form: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment about STRING
- usually just written as "string" on this page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will fix this in a separate PR (have carded it) - it should be STRING
as per the new formatting style. This page in general is in a pretty dire need of restructuring, so will try to get to it sooner rather than later. I think @gem-neo4j PR can go in as is for now.
In Unicode, a codepoint for a character that looks the same may be represented by two, or more, different codepoints. | ||
For example, the character `<` can be represented as `\uFE64` (﹤) or `\u003C` (<). | ||
To the human eye, the characters may appear identical. | ||
However, if compared, Cypher will return false as `\uFE64` does not equal `\u003C`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Cypher" appears as "Cypher (r)" here but not on other pages. I find this a bit inconsistent although I don't think that's a problem Gem could fix...
cc. @JPryce-Aklundh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first time that Cypher is mentioned on each page, we have to add that to show its status as a registered trademark. A way to fix it would be to mention Cypher earlier in the page. Will have a look.
@@ -148,6 +148,173 @@ RETURN ltrim(' hello') | |||
|
|||
====== | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I leave this entirely to your discretion, but the IS NORMALIZED section has a link to the normalize() function but not the other way around.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion @AzuObs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah nice, I can add that in :)
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
Add a new Normalization Predicate Expression.
RETURN "string" IS NORMALIZED;