Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Openstack installation r2 #111

Merged
merged 7 commits into from
Feb 14, 2024

Conversation

lapentad
Copy link
Contributor

@lapentad lapentad commented Feb 7, 2024

Renamed the md file.
Deleted extra steps and added single command for install.
Linked to the manual installation of the kpt packages for the common components.

Renamed the md file
Deleted extra steps and added single command for install

Signed-off-by: lapentafd <francesco.lapenta@est.tech>
Copy link
Contributor

@efiacor efiacor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

Co-authored-by: Fiachra Corcoran <fiachra.corcoran@est.tech>
Copy link
Member

@electrocucaracha electrocucaracha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lapentad I realized that these instructions can be applied to any setup provisioned by any Cloud provider, so it's not only applicable for OpenStack.

lapentad and others added 2 commits February 7, 2024 16:21
Changed title
Simplified start command

Co-authored-by: Victor Morales <chipahuac@hotmail.com>
Co-authored-by: Fiachra Corcoran <fiachra.corcoran@est.tech>
Copy link

netlify bot commented Feb 13, 2024

Deploy Preview for nephio ready!

Name Link
🔨 Latest commit 87a8023
🔍 Latest deploy log https://app.netlify.com/sites/nephio/deploys/65ccc647280b430008d65aaf
😎 Deploy Preview https://deploy-preview-111--nephio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@liamfallon
Copy link
Member

/approve

Copy link
Contributor

nephio-prow bot commented Feb 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Feb 13, 2024
@electrocucaracha
Copy link
Member

@lapentad This installation method is not exclusive for OpenStack, I think that it needs to be restructured to avoid any confusion.

Co-authored-by: Kushal Harish Naidu <159911459+kushnaidu@users.noreply.github.com>
@lapentad
Copy link
Contributor Author

@lapentad This installation method is not exclusive for OpenStack, I think that it needs to be restructured to avoid any confusion.

I'll change the filename and titles
/hold

Signed-off-by: lapentafd <francesco.lapenta@est.tech>
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
@lapentad
Copy link
Contributor Author

/unhold @electrocucaracha I removed the Openstack reference and made it more generic

@electrocucaracha
Copy link
Member

/lgtm

@nephio-prow nephio-prow bot added the lgtm label Feb 14, 2024
@nephio-prow nephio-prow bot merged commit 3f24ac2 into nephio-project:main Feb 14, 2024
7 of 8 checks passed
@liamfallon
Copy link
Member

/approve
/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants