Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kpt alpha to use porchctl #115

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

efiacor
Copy link
Contributor

@efiacor efiacor commented Feb 15, 2024

Restoring #110

@nephio-prow nephio-prow bot requested review from s3wong and tliron February 15, 2024 23:29
Copy link

netlify bot commented Feb 15, 2024

Deploy Preview for nephio ready!

Name Link
🔨 Latest commit 5d56e7b
🔍 Latest deploy log https://app.netlify.com/sites/nephio/deploys/65ce9e451625f30008aef823
😎 Deploy Preview https://deploy-preview-115--nephio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@efiacor efiacor requested review from electrocucaracha, CsatariGergely, liamfallon and lapentad and removed request for s3wong and tliron February 15, 2024 23:29
@efiacor
Copy link
Contributor Author

efiacor commented Feb 15, 2024

@electrocucaracha
@efiacor it seems like there is a rebase conflict on this PR, and could you include a porchctl as part of the prerequisites?

Done. I will need to update the porch docs to include an install guide asap. Linked to the release page on gh for now. We also need to do an official release as it is still in pre release state.

@electrocucaracha
Copy link
Member

/lgtm

@liamfallon
Copy link
Member

/lgtm
/approve

Copy link
Contributor

nephio-prow bot commented Feb 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Feb 16, 2024
@nephio-prow nephio-prow bot merged commit 6097320 into nephio-project:main Feb 16, 2024
8 checks passed
@efiacor efiacor deleted the update_to_use_porchctl branch December 4, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants