Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up porch guides #196

Merged
merged 3 commits into from
Dec 13, 2024
Merged

Conversation

efiacor
Copy link
Contributor

@efiacor efiacor commented Dec 9, 2024

Removing kpt alpha cmds.
Condensing porchctl guides into 1.
Rename the porch user guide section.
Minor typo fixes and clean up.

@nephio-prow nephio-prow bot requested review from johnbelamaric and s3wong December 9, 2024 18:38
Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for nephio ready!

Name Link
🔨 Latest commit 508c12f
🔍 Latest deploy log https://app.netlify.com/sites/nephio/deploys/67573eacb9c41300082d8d72
😎 Deploy Preview https://deploy-preview-196--nephio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@efiacor efiacor added the documentation Improvements or additions to documentation label Dec 9, 2024
@efiacor
Copy link
Contributor Author

efiacor commented Dec 9, 2024

/retest

Copy link
Member

@liamfallon liamfallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@nephio-prow nephio-prow bot added the approved label Dec 10, 2024
@efiacor
Copy link
Contributor Author

efiacor commented Dec 10, 2024

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@kushnaidu
Copy link
Contributor

/approve

Copy link
Contributor

nephio-prow bot commented Dec 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Catalin-Stratulat-Ericsson, kushnaidu, liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liamfallon
Copy link
Member

/gtm

@liamfallon
Copy link
Member

/lgtm

@nephio-prow nephio-prow bot added the lgtm label Dec 12, 2024
@radoslawc radoslawc merged commit 5f65f74 into nephio-project:main Dec 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved documentation Improvements or additions to documentation lgtm
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants