Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correction of links #90

Merged
merged 35 commits into from
Jan 31, 2024
Merged

Correction of links #90

merged 35 commits into from
Jan 31, 2024

Conversation

CsatariGergely
Copy link
Contributor

@CsatariGergely CsatariGergely commented Jan 24, 2024 •
edited
Loading

I'm working on a pr to build automatic link checking. During the testing of it I had to correct a couple of links...

@CsatariGergely
Add linkcheck for plan md files
97bf6f1 
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@CsatariGergely
Add linkspector config file
e6adf7f 
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@CsatariGergely
Add verification for the linkspector config file
5bc497c 
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@CsatariGergely
Ignoring localhost links
e1cc928 
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@CsatariGergely
Fixing yaml error
9518c65 
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@CsatariGergely
Add HOSTNAME to ignore list
20f6244 
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@CsatariGergely
Addig 302 as active status code
25dcc33 
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@CsatariGergely
Ignoring the wiki link :(
cd2f753 
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@CsatariGergely
Correction of links
269eb39 
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@nephio-prow Nephio PROW
Copy link
Contributor

nephio-prow bot commented Jan 24, 2024

Hi @CsatariGergely. Thanks for your PR.

I'm waiting for a nephio-project member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CsatariGergely
Copy link
Contributor Author

/assign @johnbelamaric

@liamfallon
Copy link
Member

/ok-to-test

liamfallon and others added 4 commits January 24, 2024 21:36
@liamfallon
Change owners (nephio-project#92)
e4f9b03 
As agreed at SIG-2 meeting, addition of Liam Fallon to the OWNERS file
on the doc repo.
@CsatariGergely
Removing unecesary ignore link
9629959 
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@CsatariGergely
Fixing broken links in glossary
b4fc452 
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@CsatariGergely
Merge branch 'correction-of-links' of github.com:nokia/nephio-docs in…
426f5a0 
…to correction-of-links
@CsatariGergely
Copy link
Contributor Author

/assign @liamfallon
/assign @tliron

@liamfallon
Copy link
Member

/approve

@nephio-prow nephio-prow bot added the approved label Jan 25, 2024
@liamfallon
Copy link
Member

Could we get one more approval on this before merging?

efiacor
efiacor reviewed Jan 25, 2024
View reviewed changes
Copy link
Contributor

@efiacor efiacor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment

content/en/docs/guides/install-guides/install-on-byoc.md Show resolved Hide resolved
CsatariGergely and others added 7 commits January 26, 2024 09:25
@CsatariGergely
Fixing typo in the footer (nephio-project#96)
da41955 
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@spaitsbence
reordering installation guides (nephio-project#87)
4be361c
@liamfallon
Revert inadvertent check in of file to documentation (nephio-project#93)
2d9a3f3 
The developer guide has already been moved to to
content/en/docs/guides/contributor-guides. It was inadvertently added in
PR-92 and should be deleted here.
@arora-sagar
Updating docs for R2 (nephio-project#85)
7365ed2 
Updating documentation for release 2

- Installation guide for GCE
- Exercises for OAI and Free5GC
@electrocucaracha
Update Sandbox R2 documentation (nephio-project#95)
ce39c8b 
This change updates the instructions required to set up a Sandbox
environment with the R2 changes.

Signed-off-by: Victor Morales <v.morales@samsung.com>
@CsatariGergely @efiacor
Update content/en/docs/guides/install-guides/install-on-byoc.md
a0d97a8 
Co-authored-by: Fiachra Corcoran <fiachra.corcoran@est.tech>
@CsatariGergely
Fixing relative links
9601101 
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
liamfallon
liamfallon reviewed Jan 30, 2024
View reviewed changes
content/en/docs/guides/user-guides/_index.md Outdated

## Next Steps

* Learn more about the Nephio [controllers]({{< relref "controllers.md">}})
* Learn more about the Nephio controllers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to keep a link here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes and no :)
Yes, in the final documentation we need a link there.
But I forgot tho move the controllers.md file and the link is broken now.
I move back the file and restore the link in #77

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I forgot tho move the controllers.md file and the link is broken now.

OK, I'll check on #77 and see if we can get it merged.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I forgot tho move the controllers.md file and the link is broken now.

OK, I'll check on #77 and see if we can get it merged.

#77 is merged now so maybe we can fix the link.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've rebased 60878b4 and a couple other commits (plus fixed some new link errors :))

tliron and others added 3 commits January 30, 2024 10:38
@tliron
Merge pull request nephio-project#91 from nokia/add-linkcheck
b1b2cf3 
Add linkcheck GitHub workflow
@electrocucaracha
Remove documentation typos (nephio-project#98)
5c06bfd 
This change updates the word list file used by tox to detect typos and
fixes some existing typos in the current documentation

Signed-off-by: Victor Morales <v.morales@samsung.com>
@liamfallon
Fix exercise links (nephio-project#99)
0635574 
The original Free5Gc exercises were renamed and the OAI exercises were
added in a previous PR. This PR fixes the broken links to the Free5GC
exercises and adds links to the OAI exercises in documents where the
exercise links were broken.
@CsatariGergely CsatariGergely mentioned this pull request Jan 31, 2024
Merged
CsatariGergely and others added 8 commits January 31, 2024 09:29
@CsatariGergely @efiacor @liamfallon
Adding Controller user's guide (nephio-project#77)
60878b4 
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Co-authored-by: Fiachra Corcoran <fiachra.corcoran@est.tech>
Co-authored-by: Liam Fallon <35595825+liamfallon@users.noreply.github.com>
@CsatariGergely
Correction of links
7f42d65 
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@CsatariGergely
Fixing broken links in glossary
c2c1000 
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@CsatariGergely @efiacor
Update content/en/docs/guides/install-guides/install-on-byoc.md
7392ddf 
Co-authored-by: Fiachra Corcoran <fiachra.corcoran@est.tech>
@CsatariGergely
Fixing relative links
9d1c741 
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@CsatariGergely
Adding a link to the controllers user guide
bd8fb04 
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@CsatariGergely
Merge branch 'correction-of-links' of github.com:nokia/nephio-docs in…
37fd73e 
…to correction-of-links

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@CsatariGergely
Fixing links
3b4decd 
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@efiacor
Copy link
Contributor

efiacor commented Jan 31, 2024

/approve

@nephio-prow Nephio PROW
Copy link
Contributor

nephio-prow bot commented Jan 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: efiacor, liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@efiacor
Copy link
Contributor

efiacor commented Jan 31, 2024

/lgtm

@nephio-prow nephio-prow bot added the lgtm label Jan 31, 2024
@nephio-prow nephio-prow bot merged commit f6edaa2 into nephio-project:main Jan 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efiacor efiacor efiacor left review comments

@henderiw henderiw Awaiting requested review from henderiw

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

@liamfallon liamfallon Awaiting requested review from liamfallon

Assignees

@tliron tliron

@johnbelamaric johnbelamaric

@liamfallon liamfallon

@efiacor efiacor

Labels
approved lgtm ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@CsatariGergely @liamfallon @efiacor @tliron @johnbelamaric @lapentad @spaitsbence @arora-sagar @electrocucaracha