Parametric editor implementation. #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntage of built-in rendering behavior of Accordion component.
…elper factory functions.
…lue widget added. Refactoring.
|
Skipping CI for Draft Pull Request. |
kamilmadejek
changed the title
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: efiacor, kamilmadejek, liamfallon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the first implementation of a parametric editor - a concise and DRY way of creating resource editors.
Three editors for Nephio-specific resources have been fully reimplemented using
PxeParametricEditor:NephioTokenEditor->NephioTokenParametricEditorCapacityEditor->NephioCapacityParametricEditorWorkloadClusterEditor->NephioWorkloadClusterParametricEditorParametric editor concept aims to simplify editor development and maintenance by allowing developers to create editors by providing resource-specific configuration, rather than implementing every instance from scratch. The main idea relies on two core principles:
A sample configuration for a parametric editor instance looks like this (an example for
WorkloadClusterresource):At the moment, the parametric editor has support for basic user input widgets, handling of different data types (including YAML arrays and key-values), user input filtering and display customization. Next PRs will add more features and introduce new parametric editors.
Testing (on
uitestsenvironment, credentials available per request):WorkloadClusterandCapacityparametric editorsTokenparametric editorAdditional changes in this PR:
eslintsettings.