-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NAE-1544] Time zone in Date and Datetime field #116
base: release/6.4.0
Are you sure you want to change the base?
Conversation
- implemented LocaleResolver and corresponding configuration - implemented conversion for timezones - implementeed default timezone configuration using application.properties
- corrected according to sonar test
src/main/java/com/netgrif/application/engine/ApplicationEngine.java
Outdated
Show resolved
Hide resolved
src/main/java/com/netgrif/application/engine/configuration/locale/CustomLocaleResolver.java
Outdated
Show resolved
Hide resolved
src/main/java/com/netgrif/application/engine/configuration/locale/LocaleInterceptor.java
Outdated
Show resolved
Hide resolved
...a/com/netgrif/application/engine/configuration/properties/LocaleConfigurationProperties.java
Outdated
Show resolved
Hide resolved
src/main/java/com/netgrif/application/engine/importer/service/FieldFactory.java
Outdated
Show resolved
Hide resolved
- removed bean creation from ApplicationEngine - created configuration for LocaleResolverConfiguration
- renamed CustomLocaleResolver.java to LocaleResolver.java
- added Primary attribute
- changed TIMEZONE_OFFSET_HEADER_NAME to public in LocaleInterceptor
- corrected typo in LocaleConfigurationProperties
- corrected parenthesis in FieldFactory
Kudos, SonarCloud Quality Gate passed! |
- corrected according to PR
350787e
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Kudos, SonarCloud Quality Gate passed! |
# Conflicts: # src/main/groovy/com/netgrif/application/engine/petrinet/domain/dataset/logic/action/ActionDelegate.groovy
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Description
Added time zone conversion to date
Implements NAE-1544
Dependencies
No new dependencies were introduced.
Third party dependencies
No new dependencies were introduced.
Blocking Pull requests
There are no dependencies on other PR.
How Has Been This Tested?
This was tested manually and using unit tests.
Test Configuration
Checklist: