Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nae 1872 merge w/v6 #202

Open
wants to merge 160 commits into
base: release/8.0.0
Choose a base branch
from
Open

Nae 1872 merge w/v6 #202

wants to merge 160 commits into from

Conversation

renczesstefan
Copy link
Member

Description

Optimised endpoint data, corrected tests to V7, merged with 6.3.0

Implements NAE-1872

Dependencies

No new dependencies were introduced.

Third party dependencies

No new dependencies were introduced.

Blocking Pull requests

There are no dependencies on other PR.

How Has Been This Tested?

This was tested manually with postman, JProfiler and unit tests.

Test Configuration

Name Tested on
OS macOS Ventura 13.2
Runtime Java 11
Dependency Manager Maven 3.8.4
Framework version Spring Boot 2.6.2
Run parameters
Other configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes have been checked, personally or remotely, with @mazarijuraj
  • I have commented my code, particularly in hard-to-understand areas
  • I have resolved all conflicts with the target branch of the PR
  • I have updated and synced my code with the target branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes:
    • Lint test
    • Unit tests
    • Integration tests
  • I have checked my contribution with code analysis tools:
  • I have made corresponding changes to the documentation:
    • Developer documentation
    • User Guides
    • Migration Guides

mazarijuraj and others added 30 commits September 6, 2022 15:15
- initial dev commit
# Conflicts:
#	src/main/groovy/com/netgrif/application/engine/startup/DemoRunner.groovy
- update dashboard and tile processes
- add transitions for each tile type
- fix typo in action
- add reference on parent dashboard
- add save config button
- make type required
- add important things to place and arc to be able send informations to frontend
-create method that send original transition places and arcs from net  by case id
- add collectiong assignt adn finish events to highlight path
- add permissions
- change event labels
- make fields immediate in dashboard config
- remove unused configuration field in dashboard tile
- register HttpSessionEventPublisher bean
- add session event listener for session-destroy (remove impersonation context on session logout and timeout)
- add comment to UserService to explain the code
- revert demo runner
- fix circular dependency problem
# Conflicts:
#	src/main/groovy/com/netgrif/application/engine/petrinet/domain/dataset/logic/action/ActionDelegate.groovy
#	src/main/java/com/netgrif/application/engine/history/domain/dataevents/GetDataEventLog.java
#	src/main/java/com/netgrif/application/engine/history/domain/dataevents/SetDataEventLog.java
#	src/main/java/com/netgrif/application/engine/history/domain/taskevents/AssignTaskEventLog.java
#	src/main/java/com/netgrif/application/engine/history/domain/taskevents/CancelTaskEventLog.java
#	src/main/java/com/netgrif/application/engine/history/domain/taskevents/DelegateTaskEventLog.java
#	src/main/java/com/netgrif/application/engine/history/domain/taskevents/FinishTaskEventLog.java
#	src/main/java/com/netgrif/application/engine/history/domain/taskevents/TaskEventLog.java
- add impersonation event logs
- clean up impersonation service
- use service instead of repository in ImpersonationRequestFilter
- fix event logs after merge
# Conflicts:
#	src/main/java/com/netgrif/application/engine/petrinet/service/ProcessRoleService.java
- add new type: case view filter
- implemented setting of metadata for filter field
- changed component name for filter field in dashboard_tile.xml
- add SK and DE translations
- remove userlist
mazarijuraj and others added 19 commits May 5, 2023 09:57
# Conflicts:
#	src/main/groovy/com/netgrif/application/engine/petrinet/domain/dataset/logic/action/ActionDelegate.groovy
#	src/main/java/com/netgrif/application/engine/history/service/HistoryService.java
#	src/main/java/com/netgrif/application/engine/petrinet/service/PetriNetService.java
- fix history service test due to save being async
[NAE-1865] - Grid rendering performance improvement
- fix ProcessRoleServiceTest::shouldFindAllProcessRolesByPetriNet when roles are in different order
- fix TaskService::reloadTasks not resolving userRefs on case and tasks
- refactor PostalCodeImporter
- create dashboard runner
# Conflicts:
#	CHANGELOG.md
#	pom.xml
#	src/main/java/com/netgrif/application/engine/history/service/HistoryService.java
#	src/main/java/com/netgrif/application/engine/petrinet/service/PetriNetService.java
#	src/main/java/com/netgrif/application/engine/workflow/service/DataService.java
#	src/main/java/com/netgrif/application/engine/workflow/service/TaskService.java
#	src/main/java/com/netgrif/application/engine/workflow/service/WorkflowService.java
- modified CHANGELOG.md
[NAE-1881] Release 6.3.0-rc.9
- modified CHANGELOG.md
- corrected tests and pdf generator according to corrected tests
- created mixins for Jackson parsing
- corrected problem, when parsing I18nString field value
@renczesstefan renczesstefan added improvement A change that improves on an existing feature new feature A change that introduces new functionality breaking change Fix or feature that would cause existing functionality doesn't work as expected Extra Large release labels May 16, 2023
@renczesstefan renczesstefan self-assigned this May 16, 2023
@pull-request-quantifier-deprecated

This PR has 31392 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +17400 -13992
Percentile : 100%

Total files changed: 2356

Change summary by file extension:
.yml : +12 -8
.md : +22 -2
.html : +13013 -12848
.js : +1 -0
.groovy : +536 -373
.java : +1631 -470
.properties : +14 -2
.xml : +2171 -289

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Fix or feature that would cause existing functionality doesn't work as expected Extra Large improvement A change that improves on an existing feature new feature A change that introduces new functionality release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants