-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NAE-1892] Validation register #208
base: release/6.4.0
Are you sure you want to change the base?
Conversation
- implemented ValidationRegistryService - implemented IValidator and validators for each field - modified existing Validation class - modified petriflow language
- implemented ValidationRegistryService - implemented IValidator and validators for each field - modified existing Validation class - modified petriflow language - modified tests
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
# Conflicts: # src/main/groovy/com/netgrif/application/engine/petrinet/domain/dataset/logic/action/ActionDelegate.groovy # src/main/java/com/netgrif/application/engine/importer/service/FieldFactory.java
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
# Conflicts: # src/main/java/com/netgrif/application/engine/importer/service/FieldFactory.java # src/main/java/com/netgrif/application/engine/workflow/service/DataService.java
Description
Implemented backend validation register.
Implements NAE-1892
Dependencies
No new dependencies were introduced.
Third party dependencies
No new dependencies were introduced.
Blocking Pull requests
PR netgrif/petriflow#11 has to be merged before this.
How Has Been This Tested?
This was tested manually and with unit tests.
Test Configuration
Checklist: