-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NAE-1945] External resource loader #246
Conversation
- implementing our own resource loader for files from directory reources/ in root
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
src/main/java/com/netgrif/application/engine/resource/domain/NetgrifResource.java
Outdated
Show resolved
Hide resolved
src/main/java/com/netgrif/application/engine/resource/domain/NetgrifResourceLoader.java
Outdated
Show resolved
Hide resolved
src/main/java/com/netgrif/application/engine/resource/domain/NetgrifResourceLoader.java
Outdated
Show resolved
Hide resolved
src/main/java/com/netgrif/application/engine/resource/domain/NetgrifResourceLoader.java
Outdated
Show resolved
Hide resolved
src/main/java/com/netgrif/application/engine/resource/domain/NetgrifResourceLoader.java
Outdated
Show resolved
Hide resolved
...ain/java/com/netgrif/application/engine/resource/service/NetgrifResourceLoaderProcessor.java
Outdated
Show resolved
Hide resolved
...ain/java/com/netgrif/application/engine/resource/service/NetgrifResourceLoaderProcessor.java
Outdated
Show resolved
Hide resolved
- changes according to PR
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
...in/java/com/netgrif/application/engine/resource/service/ExternalResourceLoaderProcessor.java
Outdated
Show resolved
Hide resolved
src/main/java/com/netgrif/application/engine/resource/domain/ExternalResourceLoader.java
Outdated
Show resolved
Hide resolved
- refactor of prefix detection of external resource
- refactor of prefix detection of external resource
Description
Implements NAE-1945
Dependencies
none
Third party dependencies
No new dependencies were introduced
Blocking Pull requests
There are no dependencies on other PR
How Has Been This Tested?
manually
Test Configuration
Checklist: