-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NAE-1989] RunnerController refactor #264
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add mechanism for ordering NAE runners - add runner to execute custom application runner
- migrate existing runners to new mechanism - fix runner bean class resolution for AOP
- refactor sorting method so can be used outside of resolver class
- add annotation to replace runner with another runner
- fix processing of order of runners for annotations BeforeRunner, AfterRunner, and ReplaceRunner
- make replaced runner skip execution
tuplle
added
improvement
A change that improves on an existing feature
breaking change
Fix or feature that would cause existing functionality doesn't work as expected
labels
Jul 17, 2024
- removed single quotes
- added negation
- rework execution of runner, so it is controlled by engine logic instead of spring
- enable to execute runner multiple times
- fix removing replaced runner in sorted list of runners
- edit version
renczesstefan
approved these changes
Nov 11, 2024
machacjozef
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Fix or feature that would cause existing functionality doesn't work as expected
improvement
A change that improves on an existing feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The order of NAE application runners is specified by annotations
RunnerOrder
andRunnerController
class is removed as it is not needed. This new way to define the order of execution for an application runner offers more freedom to downstream applications and modules that need to define custom runners and inject them into defined order.For keeping the safe window for custom application runners the runner
ProcessApplicationStartupRunnerExecutor
is created that is scanning for a runner that implementsProcessApplicationStartupRunner
interface. The interface is dedicated for custom downstream application runners to ensure execution only in the safe window instead of injecting in the order of predefined NAE runners.Implements NAE-1989
Dependencies
No new dependencies were introduced.
Blocking Pull requests
There are no dependencies on other PR.
How Has Been This Tested?
Manually tested on current runner classes and with temporary created dummy runners to simulate different scenarious.
Test Configuration
Checklist: