Add utility class which contains methods which helps to convert HTTP1… #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/x to BHTTP messages. Motivation: Often people need to translate from HTTP1/x to BHTTP, we should provide utilities for this. Modifications: Add BinaryHttpConvert class which contain various static helper methods Result: Easily be able to convert from HTTP1/x to BHTTP.
gaosa
approved these changes
Aug 6, 2024
thomdev
reviewed
Aug 7, 2024
codec-bhttp/src/main/java/io/netty/incubator/codec/bhttp/BinaryHttpConverter.java
Show resolved
Hide resolved
gaosa
reviewed
Aug 8, 2024
| } | ||
|
|
||
| /** | ||
| * Creates a {@link FullBinaryHttpResponse} from the given {@link FullHttpRequest}. |
There was a problem hiding this comment.
{@link FullHttpRequest} -> {@link FullHttpResponse}
| * @return the created response. | ||
| */ | ||
| public static BinaryHttpResponse convert(HttpResponse response) { | ||
| if (response instanceof FullBinaryHttpRequest) { |
| * @return the created request. | ||
| */ | ||
| public static BinaryHttpRequest convert(HttpRequest request, String scheme, String authority) { | ||
| if (request instanceof FullBinaryHttpRequest) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…/x to BHTTP messages.
Motivation:
Often people need to translate from HTTP1/x to BHTTP, we should provide utilities for this.
Modifications:
Add BinaryHttpConvert class which contain various static helper methods
Result:
Easily be able to convert from HTTP1/x to BHTTP.