fix update logic

neurostuff · Aug 13, 2024 · aaf3ae1 · aaf3ae1
1 parent a3b8c14
commit aaf3ae1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/store/neurostore/resources/base.py b/store/neurostore/resources/base.py
@@ -296,6 +296,8 @@ def update_or_create(cls, data, id=None, user=None, record=None, flush=True):
             return record
 
         data["user_id"] = current_user.external_id
+        if hasattr(record, "id"):
+            data["id"] = record.id
         # check to see if duplicate
         duplicate = cls.check_duplicate(data, record)
         if duplicate:

diff --git a/store/neurostore/resources/data.py b/store/neurostore/resources/data.py
@@ -935,10 +935,15 @@ def join_tables(self, q, args):
     def check_duplicate(cls, data, record):
         study_id = data.get("study_id")
 
+        if hasattr(record, "id") and record.id == data.get("id"):
+            # not a duplicate, same record
+            return False
+
         if hasattr(record, "study") and record.study:
             study = record.study
         else:
             study = Study.query.filter_by(id=study_id).first()
+
         if not study:
             return False