Skip to content

Commit

Permalink
[nr-ebpf-agent] Add option to configure push period. (#1490)
Browse files Browse the repository at this point in the history
~This PR has a hard dependency on updating the ebpf client version --
need cut a new release for that first.~ Done in #1493
<!--
Thank you for contributing to New Relic's Helm charts. Before you submit
this PR we'd like to
make sure you are aware of our technical requirements:

*
https://github.com/newrelic-experimental/helm-charts/blob/master/CONTRIBUTING.md#technical-requirements

For a quick overview across what we will look at reviewing your PR,
please read
our review guidelines:

*
https://github.com/newrelic-experimental/helm-charts/blob/master/REVIEW_GUIDELINES.md

Following our best practices right from the start will accelerate the
review process and
help get your PR merged quicker.

When updates to your PR are requested, please add new commits and do not
squash the
history. This will make it easier to identify new changes. The PR will
be squashed
anyways when it is merged. Thanks.

For fast feedback, please @-mention maintainers that are listed in the
Chart.yaml file.

Please make sure you test your changes before you push them. Once
pushed, a Github Action
will run across your changes and do some initial checks and linting.
These checks run
very quickly. Please check the results. We would like these checks to
pass before we
even continue reviewing your changes.
-->
#### Is this a new chart
No

#### What this PR does / why we need it:
Adds option to configure push period from the ebpf agent. The eBPF agent
applies a request path clustering algorithm to reduce cardinality in
exported HTTP data. The algorithm only looks for similar request paths
within data of the same push period. This change enables customers to
increase the window under consideration for cardinality reduction if
needed.

#### Which issue this PR fixes
*(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)`
format, will close that issue when PR gets merged)*
  - fixes #

#### Special notes for your reviewer:

#### Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove
unrelated fields.]
- [x] Chart Version bumped
- [x] Variables are documented in the README.md
- [x] Title of the PR starts with chart name (e.g. `[mychartname]`)

---------

Signed-off-by: Benjamin Kilimnik <bkilimnik@pixielabs.ai>
Co-authored-by: Kartik Pattaswamy <62078498+kpattaswamy@users.noreply.github.com>
  • Loading branch information
benkilimnik and kpattaswamy authored Oct 9, 2024
1 parent ab2d1ba commit 300dc87
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 1 deletion.
2 changes: 1 addition & 1 deletion charts/nr-ebpf-agent/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.1.6
version: 0.1.7
dependencies:
- name: common-library
version: 1.1.1
Expand Down
1 change: 1 addition & 0 deletions charts/nr-ebpf-agent/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ Options that can be defined globally include `affinity`, `nodeSelector`, `tolera
| podLabels | object | `{}` | Additional labels for chart pods |
| protocols | object | `{"amqp":true,"cass":true,"dns":true,"http":true,"kafka":true,"mongodb":true,"mysql":true,"pgsql":true,"redis":true}` | The protocols (and data export scripts) to enable for tracing in the socket_tracer. |
| proxy | string | `""` | Configures the agent to send all data through the proxy specified via the otel collector. |
| pushPeriod | string | `"15"` | The periodicity in seconds at which the eBPF client pushes data to the OTel collector for export to NR. The eBPF agent applies a request path clustering algorithm to reduce cardinality in exported HTTP data. The algorithm only looks for similar request paths within data of the same push period. To increase the window under consideration for cardinality reduction, increase this value. Accepted range: 15-60. |
| stirlingSources | string | `"socket_tracer,tcp_stats"` | The source connectors (and data export scripts) to enable. Note that socket_tracer tracks http, mysql, redis, mongodb, amqp, cassandra, dns, and postgresql while tcp_stats tracks TCP metrics. |
| tableStoreDataLimitMB | string | `"250"` | The primary lever to control RAM use of the eBPF agent. Specified in MiB. |
| tolerations | list | `[]` | Sets all pods' tolerations to node taints. Can be configured also with `global.tolerations` |
Expand Down
2 changes: 2 additions & 0 deletions charts/nr-ebpf-agent/templates/nr-ebpf-agent-daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ spec:
env:
- name: DEPLOYMENT_NAME
value: {{ .Values.cluster }}
- name: PERIOD
value: "{{ .Values.pushPeriod }}"
- name: HOST_IP
valueFrom:
fieldRef:
Expand Down
5 changes: 5 additions & 0 deletions charts/nr-ebpf-agent/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@ protocols:
cass: true
dns: true
pgsql: true
# -- The periodicity in seconds at which the eBPF agent pushes data to the OTel collector for export to NR.
# The eBPF agent applies a request path clustering algorithm to reduce cardinality in exported HTTP data.
# The algorithm only looks for similar request paths within data of the same push period.
# To increase the window under consideration for cardinality reduction, increase this value. Accepted range: 15-60.
pushPeriod: "15"

# Configuration to apply on the eBPF agent daemonset.
ebpfAgent:
Expand Down

0 comments on commit 300dc87

Please sign in to comment.