Obfuscate sql for external #559
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XiXiaPdx
force-pushed
the
obfuscate-sql-for-external
branch
from
cae405b to
e284e3d
Compare
twcrone
reviewed
Nov 30, 2021
| @@ -68,7 +68,8 @@ public DefaultSlowQueryListener(String appName, double thresholdInMillis) { | |||
| } | |||
|
|
|||
| // This allows transaction traces to show slow queries directly in the trace details | |||
| tracer.setAgentAttribute(SqlTracer.SQL_PARAMETER_NAME, rawQueryString); | |||
| //todo: obfuscatedQueryString isn't correct, it could be Raw or Obfuscated. The queryConverter | |||
There was a problem hiding this comment.
Does this TODO comment need to stay in?
| } | ||
|
|
||
| private boolean queryExceedsSlowQueryThreshold(String appName) { | ||
| double threshold = ServiceFactory.getConfigService().getAgentConfig(appName).getTransactionTracerConfig().getExplainThresholdInMillis(); |
There was a problem hiding this comment.
I'm guessing we know that none of these calls can return a null and cause an NPE
meiao
force-pushed
the
obfuscate-sql-for-external
branch
from
a1d2622 to
96ccc30
Compare
meiao
reviewed
Jan 13, 2022
| @@ -43,7 +43,7 @@ public DefaultSlowQueryListener(String appName, double thresholdInMillis) { | |||
| @Override | |||
| public <T> void noticeTracer(Tracer tracer, SlowQueryDatastoreParameters<T> slowQueryDatastoreParameters) { | |||
| if (tracer.getDurationInMilliseconds() > thresholdInMillis) { | |||
| String query = (String) slowQueryDatastoreParameters.getQuery(); | |||
| String query = slowQueryDatastoreParameters.getQuery().toString(); | |||
There was a problem hiding this comment.
This fixed a ClassCastException, but it is an oversimplification that may not work for all query objects from different databases.
Ideally here it should use the queryConverter in the SlowQueryDatastoreParameters instead of assuming the toString call will return a query.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
AIT 🟢 https://javaagent-build.pdx.vm.datanerd.us/job/AIT_Configurable/203/
Sample Test App - https://github.com/XiXiaPdx/mysql-agent-testapp
significant changes:
Needs tests and one todo to resolve