Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: increased search input width in navbar component #3867

Open
wants to merge 3 commits into
base: canary
Choose a base branch
from

Conversation

successbyte
Copy link

@successbyte successbyte commented Oct 11, 2024

Closes #3771

📝 Description

The search input looked so ugly when viewed in mobile width in Navbar components in With Search Input.

⛳️ Current behavior (updates)

input in navbar looks ugly and not set properly (in style)

issue

🚀 New behavior

The input now looks perfect on size

mobile

laptop

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

just changed some tailwind styles

Summary by CodeRabbit

  • New Features
    • Enhanced responsive design for the input field in the navbar, improving usability on small screens.
    • Updated margin behavior for the navbar brand, optimizing layout across different screen sizes.

Copy link

changeset-bot bot commented Oct 11, 2024

🦋 Changeset detected

Latest commit: 3ca7731

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 11, 2024

@successbyte is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Oct 11, 2024

Walkthrough

The changes in this pull request involve modifications to the Page function in the page.tsx file, specifically updating the className property of the NavbarBrand and the classNames property of the Input component. The margin behavior for the NavbarBrand has been adjusted for different screen sizes, and a minimum width has been added to the Input component to improve its appearance on smaller screens. The overall structure of the components remains unchanged.

Changes

File Path Change Summary
apps/docs/app/examples/navbar/with-search-input/page.tsx Updated className of NavbarBrand and classNames of Input to improve responsive design.

Assessment against linked issues

Objective Addressed Explanation
Enhance search input width in navbar docs (#3771)

Possibly related PRs

  • fix(theme): fullWidth in input and select #3768: This PR addresses the fullWidth functionality in Input components, which is relevant to the modifications made to the Input component in the main PR, specifically regarding class adjustments that affect its width behavior.

Suggested labels

👀 Status: In Review

Suggested reviewers

  • wingkwong
  • jrgarciadev

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between af6e9a0 and 3ca7731.

📒 Files selected for processing (1)
  • apps/docs/app/examples/navbar/with-search-input/page.tsx (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/docs/app/examples/navbar/with-search-input/page.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 4:37am

Copy link
Member

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. sm:min-w-min seems not required
  2. avatar will be only shown half at around 345px
image

@wingkwong wingkwong added the 📋 Scope : Docs Related to the documentation label Oct 11, 2024
@successbyte
Copy link
Author

Hi friends
1- OK I well check sm:min-w-min ( that was because in large screen the avatar got out )
2- I'm gonna change the min-w-[10rem] to min-w-[8rem]

I am using Firefox on Ubuntu could you please name your browser and OS

@successbyte successbyte requested a review from wingkwong October 11, 2024 19:13
@successbyte
Copy link
Author

Hi devs
changed logo right margin in mobile screens to 0px as it's parent is justify-content: space-bertween; it works well
the bellow is 330px width screen and it works great

any changes you want I am fine and welcome 😄

Screen Shot 2024-10-11 at 23 37 22

@successbyte successbyte requested a review from macci001 October 13, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📋 Scope : Docs Related to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhancement: search Input width in navbar docs
3 participants