-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update DatePicker example to remove "time" label as time select… #4443
base: main
Are you sure you want to change the base?
Conversation
…ion is not supported in this example
|
@praharshbhatt is attempting to deploy a commit to the NextUI Inc Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe pull request involves a minor modification to the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🔇 Additional comments (2)apps/docs/content/components/date-picker/min-and-max-date.raw.jsx (2)
Switching from "Date and time" to "Date" aligns the usage with the actual functionality of the DatePicker, which does not offer time selection.
Applying the new label ensures consistency across all DatePicker components in this example. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
…ion is not supported in this example
Closes #
📝 Description
This PR updates the DatePicker example in the official documentation. The "time" label in the example is removed as the DatePicker component does not support time selection.
⛳️ Current behavior (updates)
The documentation example uses a "Date and time" label, which might mislead users into thinking that the DatePicker component supports time selection.
🚀 New behavior
The example now uses "Date" as the label, aligning with the DatePicker component's functionality and avoiding any confusion.
💣 Is this a breaking change (Yes/No):
No
📝 Additional Information
Summary by CodeRabbit