Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds setup python step in CI/CD #1316

Merged

Conversation

domna
Copy link
Contributor

@domna domna commented Oct 31, 2023

The current CI/CD does not setup the different python version and just sets the python-version environment variable. I added a step to set the python version to the one of the current matrix element.

Fixes #1317

@domna domna changed the title The CI/CD does not setup the actual python version Adds setup python step in CI/CD Oct 31, 2023
@PeterC-DLS PeterC-DLS self-requested a review November 14, 2023 10:04
Copy link
Contributor

@PeterC-DLS PeterC-DLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@PeterC-DLS
Copy link
Contributor

@domna the workflow is to merge your merge once it's been approved and you are happy with it.

@domna
Copy link
Contributor Author

domna commented Feb 8, 2024

@domna the workflow is to merge your merge once it's been approved and you are happy with it.

I see. The problem is that I don't have the rights to merge in this repo, so I cannot do it myself.

@PeterC-DLS
Copy link
Contributor

Ok, I will merge it. Thanks for your contributions.

@PeterC-DLS PeterC-DLS merged commit 9d4c4da into nexusformat:main Feb 8, 2024
4 checks passed
@domna domna deleted the check-python-versions-in-cicd branch February 8, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The CI/CD does not actually set up the python version
2 participants