Fairmat 2024: specialized base classes on top of NXprocess

[lukaspie]

Adds several new base classes that all extend NXprocess:

• NXcalibration: for describing calibration of an instrument and/or a data set (e.g., an energy axis) -> moved from contributed to base_classes
• NXdistortion: post-processing distortion corrections
• NXregistration: image registration

[phyy-nx]

NXcalibration already reviewed
NXdistortion: make a proper subclass of NXprocess, check for duplicated fields and remove them
NXregistration: make a proper subclass of NXprocess, check for duplicated fields and remove them

Accepted by NIAC vote as part of NIAC2024

[lukaspie]

Dev notes to keep track:

• NXdistortion: made a proper subclass of NXprocess, removed duplicated fields
• NXregistration: made a proper subclass of NXprocess, removed duplicated fields
• NXprocess: removed REGISTRATION, CALIBRATION, DISTORTION

depends on / blocked by:

• NXcalibration -> FAIRmat 2024: additional base classes in NXinstrument #1419

ToDo:

• rebase after FAIRmat 2024: additional base classes in NXinstrument #1419 has been merged

[lukaspie]

@phyy-nx @sanbrock as NXcalibration is now extending NXprocess, it is not used within NXprocess anymore. Therefore, we could remove it here and bring it in with #1419. In that case, this whole PR comes down to NXdistortion and NXregistration as sub-classes of NXprocess, which has already been voted for by NIAC. So if you agree, I can remove the changes to NXcalibration and then this PR should be ready to be finally reviewed. Note that the failing CI/CD also comes from NXcalibration, so that would be solved.

[phyy-nx]

@phyy-nx @sanbrock as NXcalibration is now extending NXprocess, it is not used within NXprocess anymore. Therefore, we could remove it here and bring it in with #1419. In that case, this whole PR comes down to NXdistortion and NXregistration as sub-classes of NXprocess, which has already been voted for by NIAC. So if you agree, I can remove the changes to NXcalibration and then this PR should be ready to be finally reviewed. Note that the failing CI/CD also comes from NXcalibration, so that would be solved.

Hm, the comment above says

NXcalibration already reviewed

Where was it reviewed? Also, #1419 has not been voted on but this has. Wouldn't keeping NXcalibration in this PR simplify things?

[lukaspie]

@phyy-nx @sanbrock as NXcalibration is now extending NXprocess, it is not used within NXprocess anymore. Therefore, we could remove it here and bring it in with #1419. In that case, this whole PR comes down to NXdistortion and NXregistration as sub-classes of NXprocess, which has already been voted for by NIAC. So if you agree, I can remove the changes to NXcalibration and then this PR should be ready to be finally reviewed. Note that the failing CI/CD also comes from NXcalibration, so that would be solved.

Hm, the comment above says

NXcalibration already reviewed

Where was it reviewed? Also, #1419 has not been voted on but this has. Wouldn't keeping NXcalibration in this PR simplify things?

I think #1419 was voted on here: #1452 (comment) or am I missing something? For me, it would be okay to bring it in here or in #1419, as you prefer. I just didn't want to have to update it in multiple places.

[lukaspie]

Update: I fixed the build for NXcalibration. On second though, it might actually make sense to merge NXcalibration with this PR since this is also a subclass for NXprocess. The commits are the same, so it does not really matter. In any case, any merging of NXcalibration is still blocked by #1486.

[phyy-nx]

From Telco: subclass NXregistration from NXprocess, and remove NXcalibration (already part of #1419). Then since this has been voted on, it needs an approval and can be merged.

[lukaspie]

From Telco: subclass NXregistration from NXprocess, and remove NXcalibration (already part of #1419). Then since this has been voted on, it needs an approval and can be merged.

@phyy-nx: NXregistration is now subclassed from NXprocess, and I removed NXcalibration. Should be ready for final review and merge. Thanks!

[phyy-nx]

@lukaspie ok to merge!