fix memory leak when restarting the app with feature layer enabled an…

…d max features exceeded (causing max features warning)
ngageoint · Oct 19, 2023 · 40af0ba · 40af0ba
1 parent 1fcf1c3
commit 40af0ba
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/mapcache/build.gradle b/mapcache/build.gradle
@@ -10,6 +10,12 @@ android {
         sourceCompatibility JavaVersion.VERSION_11
         targetCompatibility JavaVersion.VERSION_11
     }
+
+    allprojects {
+        tasks.withType(JavaCompile) {
+            options.compilerArgs << "-Xlint:unchecked" << "-Xlint:deprecation"
+        }
+    }
     defaultConfig {
         applicationId "mil.nga.mapcache"
         resValue "string", "applicationId", applicationId

diff --git a/mapcache/src/main/java/mil/nga/mapcache/GeoPackageMapFragment.java b/mapcache/src/main/java/mil/nga/mapcache/GeoPackageMapFragment.java
@@ -581,6 +581,11 @@ private enum EditType {
      */
     AlertDialog disclaimerDialog;
 
+    /**
+     * Max features warning popup dialog
+     */
+    AlertDialog maxFeaturesDialog;
+
     /**
      * Model that contains various states involving the map.
      */
@@ -1658,6 +1663,9 @@ public void onStop() {
         if(disclaimerDialog != null) {
             disclaimerDialog.dismiss();
         }
+        if(maxFeaturesDialog != null){
+            maxFeaturesDialog.dismiss();
+        }
         super.onStop();
     }
 
@@ -1703,7 +1711,8 @@ private void showMaxFeaturesExceeded() {
                                     }
                                     d.cancel();
                                 });
-                dialog.show();
+                maxFeaturesDialog = dialog.create();
+                maxFeaturesDialog.show();
             }
         }
     }