-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WAF policy compile instructions #5886
Conversation
247fff1
to
bb2b97d
Compare
for more information, see https://pre-commit.ci
@jasonwilliams14 Unless there's a technical requirement for it, I don't think uploading the bundle to the cluster makes sense as the last step. Since it's referenced in the policy created, I think that step should go immediately after the necessary volume and volumeMounts are created. Right now the steps assert that you reference a binary file that doesn't exist within the cluster on the premise of adding it later: since the user will have created and downloaded the bundle already, I think it's better they upload it immediately. |
docs/content/installation/integrations/app-protect-waf/compile-waf-policies.md
Outdated
Show resolved
Hide resolved
The maintenance of the Policy Bundle itself involves the App Protect Policy (that YAML object) and the sequenced workflow of ensuring that is on the shared volume of the NIC deployment prior to any change with the YAML object. |
for more information, see https://pre-commit.ci
f76ec7d
to
96eda9f
Compare
docs/content/installation/integrations/app-protect-waf/compile-waf-policies.md
Show resolved
Hide resolved
docs/content/installation/integrations/app-protect-waf/compile-waf-policies.md
Show resolved
Hide resolved
docs/content/installation/integrations/app-protect-waf/compile-waf-policies.md
Outdated
Show resolved
Hide resolved
docs/content/installation/integrations/app-protect-waf/compile-waf-policies.md
Outdated
Show resolved
Hide resolved
docs/content/installation/integrations/app-protect-waf/compile-waf-policies.md
Show resolved
Hide resolved
docs/content/installation/integrations/app-protect-waf/compile-waf-policies.md
Outdated
Show resolved
Hide resolved
…-waf-policies.md Signed-off-by: Alan Dooley <github@adubhlaoi.ch>
…-waf-policies.md Co-authored-by: Mike Jang <mi.jang@f5.com> Signed-off-by: Alan Dooley <github@adubhlaoi.ch>
✅ Deploy Preview will be available once build job completes!
|
This commit adds a new document to the WAF v4 subsection explaining how to use NGINX Instance Manager to compile WAF policies for security bundles and add them to NGINX Ingress Controller. --------- Signed-off-by: Alan Dooley <a.dooley@f5.com> Co-authored-by: Jason Williams <ja.williams@f5.com> Co-authored-by: Venktesh Shivam Patel <ve.patel@f5.com> Co-authored-by: Shaun <s.odonovan@f5.com> Co-authored-by: Mike Jang <mi.jang@f5.com>
Proposed changes
This PR is for a document describing how to use NGINX Instance Manager to compile policies for NGINX App Protect WAF for use with NGINX Ingress Controller.
Jason Williams is the author: I am editing and converting it for documentation. The first commit is largely the rough draft initially provided
Checklist
Before creating a PR, run through this checklist and mark each as complete.