Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove link to ingress example #6101

Merged
merged 2 commits into from
Jul 30, 2024
Merged

remove link to ingress example #6101

merged 2 commits into from
Jul 30, 2024

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Jul 30, 2024 •
edited
Loading

Proposed changes

  • Remove dead link to ingress example as WAF v5 only supports VS/VSR via policy

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested review from a team as code owners July 30, 2024 15:28
@vepatel vepatel added needs cherry pick Cherry pick this PR into a release branch documentation Pull requests/issues for documentation labels Jul 30, 2024
@github-actions GitHub Actions
Copy link

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/6101/

@vepatel vepatel merged commit 0f6960a into main Jul 30, 2024
48 checks passed
@vepatel vepatel deleted the docs/remove-v5-ingress branch July 30, 2024 15:38
nginx-bot pushed a commit that referenced this pull request Jul 30, 2024
@vepatel @web-flow
remove link to ingress example (#6101)
7e22186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdabelf5 pdabelf5 pdabelf5 approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation needs cherry pick Cherry pick this PR into a release branch
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vepatel @AlexFenlon @pdabelf5