Faster unaligned big endian buffer reads #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #31 introduced performance improvements for unaligned buffer reads, but it needed to be reverted for big endian readers in #45 due to correctness issues. This PR fixes the correctness issues (ie: the failing test passes) and added some additional fuzzing for good measure. Big endian buffer reads are now up to 10x faster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #31 introduced performance improvements for unaligned buffer reads, but it needed to be reverted for big endian readers in #45 due to correctness issues.
This PR fixes the correctness issues (ie: the failing test passes) and added some additional fuzzing for good measure.
Big endian buffer reads are now up to 10x faster.