try/catch

nik9000 · Oct 28, 2023 · 234521b · 234521b
1 parent 76688ee
commit 234521b
Showing 1 changed file with 17 additions and 15 deletions.
diff --git a/...mpute/src/main/java/org/elasticsearch/compute/aggregation/blockhash/BooleanBlockHash.java b/...mpute/src/main/java/org/elasticsearch/compute/aggregation/blockhash/BooleanBlockHash.java
@@ -75,28 +75,30 @@ private IntBlock add(BooleanBlock block) {
 
     @Override
     public BooleanBlock[] getKeys() {
-        BooleanBlock.Builder builder = blockFactory.newBooleanBlockBuilder(everSeen.length);
-        if (everSeen[NULL_ORD]) {
-            builder.appendNull();
-        }
-        if (everSeen[FALSE_ORD]) {
-            builder.appendBoolean(false);
-        }
-        if (everSeen[TRUE_ORD]) {
-            builder.appendBoolean(true);
+        try (BooleanBlock.Builder builder = blockFactory.newBooleanBlockBuilder(everSeen.length)) {
+            if (everSeen[NULL_ORD]) {
+                builder.appendNull();
+            }
+            if (everSeen[FALSE_ORD]) {
+                builder.appendBoolean(false);
+            }
+            if (everSeen[TRUE_ORD]) {
+                builder.appendBoolean(true);
+            }
+            return new BooleanBlock[] { builder.build() };
         }
-        return new BooleanBlock[] { builder.build() };
     }
 
     @Override
     public IntVector nonEmpty() {
-        IntVector.Builder builder = blockFactory.newIntVectorBuilder(everSeen.length);
-        for (int i = 0; i < everSeen.length; i++) {
-            if (everSeen[i]) {
-                builder.appendInt(i);
+        try (IntVector.Builder builder = blockFactory.newIntVectorBuilder(everSeen.length)) {
+            for (int i = 0; i < everSeen.length; i++) {
+                if (everSeen[i]) {
+                    builder.appendInt(i);
+                }
             }
+            return builder.build();
         }
-        return builder.build();
     }
 
     public BitArray seenGroupIds(BigArrays bigArrays) {