Skip to content

Commit

Permalink
Report full stack trace for non-state file settings transforms (elast…
Browse files Browse the repository at this point in the history
…ic#101346)

In most cases file based settings apply transformations from
configuration to cluster state. However, there exists "non state"
transformations as well. When these are run, any errors are stored in
cluster state. This commit fixes a bug in handling of these exception
cases where just the exception messages, instead of the full stack
trace, was captured.
  • Loading branch information
rjernst authored Oct 26, 2023
1 parent 54485c9 commit e99f3c3
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions docs/changelog/101346.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 101346
summary: Report full stack trace for non-state file settings transforms
area: Infra/Settings
type: bug
issues: []
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ public void onFailure(Exception e) {
@Override
public void onFailure(Exception e) {
// If we encounter an error while runnin the non-state transforms, we avoid saving any cluster state.
errorListener.accept(checkAndReportError(namespace, List.of(e.getMessage()), reservedStateVersion));
errorListener.accept(checkAndReportError(namespace, List.of(stackTrace(e)), reservedStateVersion));
}
});
}
Expand Down

0 comments on commit e99f3c3

Please sign in to comment.