WIP Native elixir #1020
Draft
WIP Native elixir #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qa: Remove test log files qa: Remove 'unique' on elixir modules qa: Remove 'LOCAL_DEPS_DIRS' changes qa: Remove duplicate targets qa: Remove 'fix' of setting the elixir commit to 'main' qa: Move 'GetDeps' fun to its own macro within hex.mk Some cleanup + if crypto isn't installed, fail earlier Add suites to CI
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
|
Once all tests pass again in RabbitMQ this can be merged. But perhaps leave it hanging until after Christmas. |
This comment was marked as resolved.
This comment was marked as resolved.
essen
commented
Dec 16, 2024
| endif | ||
|
|
||
| .PHONY: autopatch-$(call query_name,$1) | ||
|
|
||
| ifeq ($1,elixir) | ||
| autopatch-elixir:: | ||
| ln -s lib/elixir/ebin $(DEPS_DIR)/elixir/ |
|
For eunit we need to filter out the Elixir.*.beam files. Edit: No and it's hard to know whether eunit is used or not. Perhaps have a variable to force disable it. |
artman41
reviewed
Dec 24, 2024
| @@ -0,0 +1,145 @@ | |||
| # Copyright (c) 2024, Tyler Hughes <artman41@gmail.com> | |||
There was a problem hiding this comment.
sorry to be awkward Essen, any chance I could get this swapped to my dev email tyler@tylerhughes.dev?
No worries if not, I appreciate it's a tiny thing 😅
There was a problem hiding this comment.
Will do. I think I used the email from your PR's commits. If I forget a PR updating it is of course welcome.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heavily modified version of #979