Skip to content

Commit

Permalink
Use libjavascriptcoregtk-4.1 by default.
Browse files Browse the repository at this point in the history
  • Loading branch information
nmoinvaz committed Dec 20, 2024
1 parent 6c6f61c commit 6db78ae
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 2 deletions.
12 changes: 11 additions & 1 deletion .github/workflows/ubuntu.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,17 @@ jobs:
- name: Install dependencies
run: |
sudo apt update
sudo apt install -y llvm-14 ninja-build libgconf2-dev libjavascriptcoregtk-4.0-dev
sudo apt install -y llvm-14 ninja-build
major_version=$(lsb_release -rs | cut -d'.' -f1)
if [ "$major_version" -le "22" ]; then
sudo apt install -y libgconf2-dev
fi
if [ "$major_version" -ge "24" ]; then
sudo apt install -y libjavascriptcoregtk-4.1-dev
else
sudo apt install -y libjavascriptcoregtk-4.0-dev
fi
- name: Checkout repository
uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ elseif(UNIX)
# Don't link libraries at compile time since we dynamically load them at runtime
target_include_directories(proxyres PRIVATE ${GConf_INCLUDE_DIRS})

pkg_search_module(JSCoreGTK REQUIRED javascriptcoregtk-4.0 javascriptcoregtk-3.0 javascriptcoregtk-1.0)
pkg_search_module(JSCoreGTK REQUIRED javascriptcoregtk-4.1 javascriptcoregtk-4.0 javascriptcoregtk-3.0 javascriptcoregtk-1.0)
# Don't link libraries at compile time since we dynamically load them at runtime
target_include_directories(proxyres PRIVATE ${JSCoreGTK_INCLUDE_DIRS})

Expand Down

0 comments on commit 6db78ae

Please sign in to comment.