Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winrt: net_adapter functions do not require PROXYRES_EXECUTE #54

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

sergio-nsk
Copy link
Collaborator

No description provided.

@sergio-nsk sergio-nsk added the bug Something isn't working label Dec 6, 2023
@sergio-nsk sergio-nsk requested a review from nmoinvaz December 6, 2023 21:44
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (863f4af) 55.57% compared to head (c7ede57) 55.57%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #54   +/-   ##
=======================================
  Coverage   55.57%   55.57%           
=======================================
  Files          53       53           
  Lines        4605     4605           
  Branches     1062     1062           
=======================================
  Hits         2559     2559           
  Misses       1375     1375           
  Partials      671      671           
Flag Coverage Δ
macos 44.48% <ø> (ø)
ubuntu 53.41% <ø> (ø)
ubuntu_curl 53.10% <ø> (ø)
windows 56.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergio-nsk sergio-nsk enabled auto-merge (rebase) December 7, 2023 01:16
@nmoinvaz
Copy link
Owner

nmoinvaz commented Dec 7, 2023

net adapter functions are not used unless PROXYRES_EXECUTE though right?

@sergio-nsk
Copy link
Collaborator Author

sergio-nsk commented Dec 7, 2023

net adapter functions are not used unless PROXYRES_EXECUTE though right?

They are used regardless of PROXYRES_EXECUTE. I did not push client changes, waiting for the submodule update - there is Socket_GetMACAddress() that uses net adapter functions.

@sergio-nsk sergio-nsk merged commit 17c641c into master Dec 8, 2023
16 of 18 checks passed
@sergio-nsk sergio-nsk deleted the sergey/winrt/2 branch December 8, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants