Merge pull request #540 from noborus/add-comment-previousSection

Add a comment about timeout
noborus · Apr 26, 2024 · 3cefe59 · 3cefe59
2 parents 64bd638 + ca8b105
commit 3cefe59
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/oviewer/input_search.go b/oviewer/input_search.go
@@ -14,6 +14,7 @@ const (
 	filter
 )
 
+// setSearchMode sets the inputMode to Search.
 func (root *Root) setCommonSearchMode() {
 	input := root.input
 	input.reset()

diff --git a/oviewer/move_vertical.go b/oviewer/move_vertical.go
@@ -296,6 +296,9 @@ func (m *Document) movePrevSection() error {
 
 // prevSection returns the line number of the previous section.
 func (m *Document) prevSection(n int) (int, error) {
+	// TODO: Timeout should be specified in the caller instead of here.
+	// If it takes a long time to find the section header,
+	// it will freeze during that time, so a timeout is set.
 	ctx := context.Background()
 	ctx, cancel := context.WithTimeout(ctx, sectionTimeOut*time.Millisecond)
 	defer cancel()