Improve escape sequence compatibility #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
noborus
commented
Nov 14, 2024
noborus
commented
- Enhanced handling of invalid values in escape sequences to better match terminal and `less`` behavior.
- Updated related functions to ensure compatibility.
- Improved error handling and reporting for invalid escape sequences.
- Enhanced handling of invalid values in escape sequences to better match terminal and `less`` behavior. - Updated related functions to ensure compatibility. - Improved error handling and reporting for invalid escape sequences.
ccoVeille
suggested changes
Nov 15, 2024
| @@ -90,6 +96,9 @@ func (es *escapeSequence) convert(st *parseState) bool { | |||
| case mainc >= '0' && mainc <= 'f': | |||
| es.parameter.WriteRune(mainc) | |||
| return true | |||
| case mainc < 0x40: | |||
There was a problem hiding this comment.
This is a magical number here, you should either explain why it's 0x40, or add a constant with a meaningful name
0x40 is @ right? 0x41 is A
What is this if statement about?
Checking that anything before @ is handled in a common way? But then @ is not caught?
I'm still unsure about what the code does
| num, err := strconv.Atoi(str) | ||
| if err != nil { | ||
| for _, char := range str { | ||
| if char >= 0x40 { |
| } | ||
|
|
||
| // csColor parses 8-bit color and 24-bit color. | ||
| func csColor(fields []string) (int, string) { | ||
| if len(fields) < 2 { | ||
| return 0, "" | ||
| } | ||
| if fields[1] == "" { | ||
| return 1, "" |
There was a problem hiding this comment.
Please use constant for 0-5 and give them meaningful names
| s.Bold = true | ||
| case "2", "02": | ||
| case 2: |
There was a problem hiding this comment.
Please use constants for all these numbers, and give them names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.