Add function to wait for EOF #673
Merged
+29
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `WaitEOF` function to wait for EOF notification.
ccoVeille
reviewed
Dec 25, 2024
ccoVeille
reviewed
Dec 25, 2024
| @@ -59,6 +59,8 @@ type Document struct { | |||
| // alignConv is an interface that converts alignment. | |||
| alignConv *align | |||
|
|
|||
| cond *sync.Cond | |||
There was a problem hiding this comment.
Do you really need this?
I have never faced sync.Cond until now, so I looked at documentation
For many simple use cases, users will be better off using channels than a Cond
There was a problem hiding this comment.
Do you really need this?
I have never faced sync.Cond until now, so I looked at documentation
For many simple use cases, users will be better off using channels than a Cond
That's a good point.
I thought it would be best to use Broadcast (), which does not have to be received or does not need to receive more than one.
I think it is difficult to implement it without mistakes on a channel.
Co-authored-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com>
ccoVeille
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
WaitEOFfunction to wait for EOF notification.