Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved comments and updated modules #676

Merged
merged 5 commits into from
Dec 30, 2024
Merged

Improved comments and updated modules #676

merged 5 commits into from
Dec 30, 2024

Conversation

noborus
Copy link
Owner

@noborus noborus commented Dec 29, 2024

No description provided.

ccoVeille
ccoVeille reviewed Dec 29, 2024
View reviewed changes
Copy link
Contributor

@ccoVeille ccoVeille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use godoc link (available since Go 1.19

Here are some

oviewer/control.go Outdated Show resolved Hide resolved
oviewer/document.go Outdated Show resolved Hide resolved
oviewer/document.go Outdated Show resolved Hide resolved
@noborus
Copy link
Owner Author

noborus commented Dec 29, 2024

You could use godoc link (available since Go 1.19

Here are some

nice! thank you.

noborus and others added 3 commits December 29, 2024 21:14
@noborus @ccoVeille
Update oviewer/control.go
0bb6797 
Co-authored-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com>
@noborus @ccoVeille
Update oviewer/document.go
6063da6 
Co-authored-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com>
@noborus @ccoVeille
Update oviewer/document.go
e3fad6d 
Co-authored-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com>
@ccoVeille
Copy link
Contributor

ccoVeille commented Dec 29, 2024 •
edited
Loading

Use go doc -open (something like that) to check locally

I'm unsure [requestLoad] worked [Document.requestLoad] might the right syntax

@noborus
Copy link
Owner Author

noborus commented Dec 30, 2024

Use go doc -open (something like that) to check locally

I'm unsure [requestLoad] worked [Document.requestLoad] might the right syntax

thank you. I confirmed it.

@noborus noborus merged commit 18a05c5 into master Dec 30, 2024
8 checks passed
@noborus noborus deleted the improve-comments branch December 30, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccoVeille ccoVeille ccoVeille left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noborus @ccoVeille