Test on GitHub Actions windows-2025 image
#3116
Conversation
cclauss
force-pushed
the
GitHub-Actions-windows-2025
branch
from
a40c064 to
aa2aa3e
Compare
cclauss
force-pushed
the
GitHub-Actions-windows-2025
branch
from
aa2aa3e to
dce3aef
Compare
cclauss
changed the title
cclauss
changed the title
windows-2025 image
lib/find-visualstudio.js
Outdated
| @@ -456,6 +457,8 @@ class VisualStudioFinder { | |||
| return 'v142' | |||
| } else if (versionYear === 2022) { | |||
| return 'v143' | |||
| } else if (versionYear === 2025) { | |||
| return 'v143' // Fix this when Visual Studio 2025 ships | |||
There was a problem hiding this comment.
Is these VS 2025 changes required now? Shall we add these when VS 2025 is actually released?
There was a problem hiding this comment.
These tests will fail on Windows 2025 without these mods because Windows 2025 currently ships with Visual Studio 2022.
That is probably a question for @StefanStojanovic. I am not a Windows user but if Windows 2025 is available on GitHub Actions, it will not be long before new issues are opened about using it. The great news is that it seems to work out-of-the box and in some tests is quite a bit faster. The only incompatibility appears in our integration tests because we are still many months away from having a Visual Studio 2025.
There was a problem hiding this comment.
The way I see it, Windows and VS versions are not connected. We are combining them for our tests (Win2019 + VS2019 and Win2022 + VS2022), but that is not mandatory.
@cclauss can you please explain this part of the comment: These tests will fail on Windows 2025 without these mods because Windows 2025 currently ships with Visual Studio 2022. Does that mean that only changing the yml files results in test failures?
There was a problem hiding this comment.
If you make the changes to the YAML files but do not make the changes to lib/find-visualstudio.js then the Windows 2025 tests will fail.
There was a problem hiding this comment.
Windows and VS versions are not connected.
My sense is that lib/find-visualstudio.js assumes that they are connected.
There was a problem hiding this comment.
legendecas#2 I tried to remove the change in find-visualstudio.js and the CI is green. IIRC the failure was caused by specifying VS2025 in GHA and it is not installed on GitHub Action windows 2025.
There was a problem hiding this comment.
Nice! Thanks @legendecas you are correct.
https://learn.microsoft.com/en-us/windows-server/get-started/windows-server-release-info
https://learn.microsoft.com/en-us/windows-server/get-started/whats-new-windows-server-2025
Windows 2025 currently ships with Visual Studio 2022.
vswhere -latest -property installationPathChecklist
npm install && npm run lint && npm testpassesDescription of change