Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use Ninja in action workflows #37499

Closed
wants to merge 5 commits into from
Closed

build: use Ninja in action workflows #37499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8213b3c
build: use Ninja in action workflows
targos Feb 24, 2021
c117869
fixup! build: use Ninja in action workflows
targos Feb 24, 2021
b7d5022
fixup! fixup! build: use Ninja in action workflows
targos Feb 24, 2021
f2321c0
fixup! fixup! fixup! build: use Ninja in action workflows
targos Feb 24, 2021
1005055
fixup! fixup! fixup! fixup! build: use Ninja in action workflows
targos Feb 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/build-tarball.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@ on:
- v[0-9]+.x

env:
PYTHON_VERSION: 3.9
FLAKY_TESTS: dontcare
CONFIG_FLAGS: --ninja

jobs:
build-tarball:
if: github.event.pull_request.draft == false
env:
PYTHON_VERSION: 3.9
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Expand All @@ -39,8 +39,6 @@ jobs:
name: tarballs
path: tarballs
test-tarball-linux:
env:
PYTHON_VERSION: 3.9
needs: build-tarball
runs-on: ubuntu-latest
steps:
Expand All @@ -49,6 +47,8 @@ jobs:
uses: actions/setup-python@v2
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Install Ninja
run: sudo apt-get install ninja-build
- name: Environment Information
run: npx envinfo
- name: Download tarball
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/coverage-linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ on:
env:
PYTHON_VERSION: 3.9
FLAKY_TESTS: dontcare
CONFIG_FLAGS: --error-on-warn --coverage --ninja

jobs:
coverage-linux:
Expand All @@ -30,12 +31,14 @@ jobs:
uses: actions/setup-python@v2
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Install Ninja
run: sudo apt-get install ninja-build
- name: Environment Information
run: npx envinfo
- name: Install gcovr
run: pip install gcovr==4.2
- name: Build
run: make build-ci -j2 V=1 CONFIG_FLAGS="--error-on-warn --coverage"
run: make build-ci -j2 V=1
# TODO(bcoe): fix the couple tests that fail with the inspector enabled.
# The cause is most likely coverage's use of the inspector.
- name: Test
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/test-asan.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,15 @@ jobs:
CC: clang
CXX: clang++
LINK: clang++
CONFIG_FLAGS: --enable-asan
CONFIG_FLAGS: --enable-asan --ninja
steps:
- uses: actions/checkout@v2
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@v2
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Install Ninja
run: sudo apt-get install ninja-build
- name: Environment Information
run: npx envinfo
- name: Build
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/test-linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ on:
env:
PYTHON_VERSION: 3.9
FLAKY_TESTS: dontcare
CONFIG_FLAGS: --error-on-warn --ninja

jobs:
test-linux:
Expand All @@ -23,9 +24,11 @@ jobs:
uses: actions/setup-python@v2
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Install Ninja
run: sudo apt-get install ninja-build
- name: Environment Information
run: npx envinfo
- name: Build
run: make build-ci -j2 V=1 CONFIG_FLAGS="--error-on-warn"
run: make build-ci -j2 V=1
- name: Test
run: make run-ci -j2 V=1 TEST_CI_ARGS="-p actions"
5 changes: 4 additions & 1 deletion .github/workflows/test-macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ on:
env:
PYTHON_VERSION: 3.9
FLAKY_TESTS: dontcare
CONFIG_FLAGS: --error-on-warn --ninja

jobs:
test-macOS:
Expand All @@ -23,9 +24,11 @@ jobs:
uses: actions/setup-python@v2
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Install Ninja
run: brew install ninja
- name: Environment Information
run: npx envinfo
- name: Build
run: make build-ci -j2 V=1 CONFIG_FLAGS="--error-on-warn"
run: make build-ci -j2 V=1
- name: Test
run: make run-ci -j2 V=1 TEST_CI_ARGS="-p actions"