Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: lock the thread properly in snapshot builder #56327

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

src: lock the thread properly in snapshot builder #56327

wants to merge 1 commit into from
+2 −0

Conversation

joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Dec 20, 2024 •
edited
Loading

Otherwise it can crash DCHECK when V8 expects that at least someone is locking the current thread.

Fixes: nodejs/node-v8#294

@joyeecheung
src: lock the thread properly in snapshot builder
056befb 
Otherwise it can crash DCHECK when V8 expects that at least someone
is locking the current thread.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Dec 20, 2024
@joyeecheung joyeecheung mentioned this pull request Dec 20, 2024
Open
@codecov Codecov
Copy link

codecov bot commented Dec 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.54%. Comparing base (fd8de67) to head (056befb).
Report is 13 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #56327   +/-   ##
=======================================
  Coverage   88.54%   88.54%           
=======================================
  Files         657      657           
  Lines      190295   190394   +99     
  Branches    36536    36544    +8     
=======================================
+ Hits       168491   168582   +91     
- Misses      14981    14991   +10     
+ Partials     6823     6821    -2
Files with missing lines Coverage Δ
src/node_snapshotable.cc 75.16% <100.00%> (+0.02%) ⬆️

... and 35 files with indirect coverage changes

@targos
Copy link
Member

targos commented Dec 21, 2024

Just to help me understand, do we have to lock because of this check?
https://github.com/v8/v8/blob/cf11e59dd2e7c0478c9332f7d36d4b88954725df/src/heap/cppgc-js/cpp-heap.cc#L1308-L1315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node_mksnapshot fails for debug builds
4 participants
@joyeecheung @nodejs-github-bot @targos @jasnell