Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix 'Down the rabbit-hole' link on 'Publishing a package' page #7373

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

yuyokk
Copy link
Contributor

@yuyokk yuyokk commented Dec 30, 2024

Description

Fix URI fragment for "Down the rabbit-hole" links on "Publishing a package" page

Validation

Current links redirect to https://nodejs.org/en/learn/modules/publishing-a-package#down-the-rabbithole
Correct one is https://nodejs.org/en/learn/modules/publishing-a-package#down-the-rabbit-hole

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@yuyokk yuyokk requested a review from a team as a code owner December 30, 2024 21:49
Copy link

vercel bot commented Dec 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Dec 30, 2024 9:50pm

Copy link
Member

@mikeesto mikeesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

github-actions bot commented Jan 2, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 97 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 97 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

Copy link
Contributor

github-actions bot commented Jan 2, 2025

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 85%
83.85% (587/700) 64.74% (180/278) 82.7% (110/133)

Unit Test Report

Tests Skipped Failures Errors Time
123 0 💤 0 ❌ 0 🔥 5.048s ⏱️

@mikeesto mikeesto added this pull request to the merge queue Jan 2, 2025
Merged via the queue into nodejs:main with commit 27c8deb Jan 2, 2025
13 checks passed
@yuyokk yuyokk deleted the fix-links branch January 2, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants