Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep(punycode.js), reduced indirection, spread operator #35

Merged
merged 6 commits into from
Apr 19, 2024

Conversation

msimerson
Copy link
Contributor

@msimerson msimerson commented Apr 18, 2024

  • punycode.js: also update package.json
  • remove unused indirection (init_wildduck_shared)
  • use es6 ... to reduce boilerplate
  • disable eslint prefer-const rule

@msimerson msimerson changed the title Punycode dep(punycode.js), reduced indirection, spread operator Apr 18, 2024
@andris9
Copy link
Member

andris9 commented Apr 18, 2024

I don't understand why did you change init_wildduck_shared and open_database functions? open_database is called by init_wildduck_shared and this is called by plugin.register_hook('init_… hooks.

@louis-lau
Copy link
Member

Also, prefer-const seems like a good rule to have?

@msimerson
Copy link
Contributor Author

msimerson commented Apr 18, 2024

Why not call open_database directly in register? What is the logic behind calling a function which does nothing besides calling another function with rearranged arguments.

I also agree with prefer-const, but that doesn't seem to be the preferred style. I've moved the prefer-const conversation to PR #36

@msimerson
Copy link
Contributor Author

Now I understand your confusion. I forgot to update the call in register to open_database. PR updated.

@andris9 andris9 merged commit 0e9e3f1 into nodemailer:master Apr 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants