Replaced Json by STONJSON, removing dependency on Json #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noha
approved these changes
Dec 12, 2023
|
Thanks! I never liked the addition of the extra dependency. Not sure the commandline handler is used. At least it was used by the pillar guys |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11 by replacing usage of
Jsonclass bySTONJSON, removing dependency on unmaintained JSON project on smalltalkhub that cannot be loaded into Pharo 12.This is an alternative to #12 that proposes moving the Json project, while this one removes the dependency on it altogether.
Note that this
MustacheCommandLineHandlerclass has no tests, so I am not completely sure this change does not have any side effects.