add pitch / playback speed #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-fl3
reviewed
May 10, 2023
| @@ -212,17 +222,23 @@ impl Mixer { | |||
| let mut i = 0; | |||
|
|
|||
| while let Some(sound) = self.mixer_state.get_mut(i) { | |||
| let pitch = sound.pitch; | |||
| let volume = sound.volume; | |||
| let mut remainder = buffer.len(); | |||
|
|
|||
| loop { | |||
There was a problem hiding this comment.
I am not quite sure if this is enough - from what I understand, without interpolation+some filtering, pitch by simple re-sampling with nearest neighbor scaling does not sound very good.
Also I am not sure if effects belong to the fill_audio_buffer function
There was a problem hiding this comment.
added linear interpolation between sample entries. I don't hear much of a difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Absolute beginner in audio. Hope someone can approve.