Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/runtime macro panic #496

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jamescarterbell
Copy link
Contributor

Removes the build script check for selecting a runtime. This check prevents building libraries that rely on ntex without using any runtime features.

Instead, moves the runtime checks to the two main places I think would matter for build time checking: test and main macros (with the runtime failures still left in place).

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.02%. Comparing base (69b0fe4) to head (223cd4f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #496   +/-   ##
=======================================
  Coverage   91.02%   91.02%           
=======================================
  Files         198      198           
  Lines       32355    32355           
=======================================
  Hits        29450    29450           
  Misses       2905     2905           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fafhrd91
Copy link
Member

fafhrd91 commented Jan 4, 2025

i changed ntex-rt already, this change is not needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants