feat: display audio file icon when no thumbnailUrl and encodingFormat is audio #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is audio Signed-off-by: James Chien <james@numbersprotocol.io>
|
in the description, did you mean audio file svg? |
Yes, it's a typo. Updated |
olgahaha
approved these changes
Nov 13, 2024
|
just to confirm, do you want to use the gray SVG instead of the gray music icon? |
@olgahaha Which gray music icon you are talking about? SVG code is preferred over icons from remote url as it should be faster to load in browser. |
Signed-off-by: James Chien <james@numbersprotocol.io>
shc261392
force-pushed
the
feature-audio-display
branch
from
d4c8f51 to
e504623
Compare
olgahaha
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
thumbnailUrlavailable andencodingFormatis audio