Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): use @nuxt/kit to load nuxt config #205

Merged
merged 3 commits into from
Jan 6, 2025
Merged

fix(cli): use @nuxt/kit to load nuxt config #205

merged 3 commits into from
Jan 6, 2025

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

using jiti to import nuxt.config would have issues with undefined defineNuxtConfig.

Using loadNuxtConfig also allows us to respect (and identify!) whether layers have disabled telemetry

@danielroe danielroe merged commit 0914f26 into main Jan 6, 2025
3 checks passed
@danielroe danielroe deleted the fix/kit-load branch January 6, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant